MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D136846#3890699 <https://reviews.llvm.org/D136846#3890699>, @wenlei wrote:

> Did you see measurable perf boost with profi on autofdo? Or what motivated 
> you to turn on profi? In most cases, profi helps when csspgo is used (instead 
> of traditional autofdo).

LG in my view, but @wenlei may have something to add.



================
Comment at: clang/test/Driver/pgo-sample-use-profi.c:2
+/// Test if profi flat is enabled in frontend as user-facing feature.
+// RUN: %clang -c -fsample-profile-use-profi 
-fprofile-sample-use=%S/../CodeGen/Inputs/pgo-sample.prof -### %s 2>&1 | 
FileCheck %s
+
----------------
Such a cross-directory test file reference is generally not acceptable. Use a 
dummy file `-fprofile-sample-use=/dev/null`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136846/new/

https://reviews.llvm.org/D136846

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to