Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:40 +.. option:: BlockedFunctions + A semicolon-separated list of names of functions who's parameters do not + participate in the resolution. ---------------- Please separate with newline. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:50 + + A string specifying which include-style is used, `llvm` or `google`. Default + is `llvm`. ---------------- Could such option be shared between different checks? Or even rely on `.clang-format`? ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:71 + + This check is also unable to detect last usages for fields, if the parent + class is destructed after the last usage. ---------------- Please unindent. It's not a code. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:73 + class is destructed after the last usage. \ No newline at end of file ---------------- Please add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
