zahiraam added a comment. In D138117#3932688 <https://reviews.llvm.org/D138117#3932688>, @kawashima-fj wrote:
> In D138117#3931109 <https://reviews.llvm.org/D138117#3931109>, @zahiraam > wrote: > >> It would probably be better to make these changes with the appropriate code >> changes you are making for each semantic mode. And may be keep this patch >> only for the other changes you are proposing. > > Sorry, I don't understand what you mean. > I didn't/won't change code (except a bug fix of D138109 > <https://reviews.llvm.org/D138109>) or propose changing code. > I just want the document to be consistent with the existing code by this > patch. > Are you saying about D138109 <https://reviews.llvm.org/D138109>? Or other > things? > > (Sorry, I'm not a native English speaker. My understanding may be bad.) @@kawashima-fj no need to apologize! What I meant was that the changes about the semantic mode approx-func that you made here https://reviews.llvm.org/D138109 , should have included the changes that you are making in this patch about approx-func. In general, the changes to the users' manual should be in the same patch than the code changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
