krsch added inline comments.
================ Comment at: clang/lib/Sema/SemaFixItUtils.cpp:136-137 + // Do no take address of const pointer to get void* + const PointerType *FromPtrTy = dyn_cast<PointerType>(FromQTy); + const PointerType *ToPtrTy = dyn_cast<PointerType>(ToQTy); + if (FromPtrTy && FromPtrTy->getPointeeType().isConstQualified() && ---------------- xazax.hun wrote: > xazax.hun wrote: > > Nit: we usually try to avoid repeating types. > Although the rest of the function clearly does not follow this guideline so > feel free to leave it as is. The rest of the function was made this way in commit 1e95bc0f4063e, so I thought this is the style for this part of the codebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ https://reviews.llvm.org/D138426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
