arsenm added a comment.

In D138473#3944586 <https://reviews.llvm.org/D138473#3944586>, @yaxunl wrote:

> Are you sure these functions are equivalent? we do not have a comprehensive 
> test for these functions regarding accuracy.

These are ultimately simple bit extracts. The library implementation just calls 
these intrinsics. The only difference from the current library code and here is 
a check to handle infinities and nans, which the ISA manual suggests is 
unnecessary. I have another patch to eliminate the check there


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138473/new/

https://reviews.llvm.org/D138473

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to