klimek added a comment.

For non-functional clean-ups generally llvm doesn't require pre-commit review - 
I did communicate here so people involved in the original change wouldn't miss 
the clean-up. I do agree that what commits to pre-review is a fine line, and 
usually try to err on the side of pre-review; I'll take your feedback into 
consideration for future changes.

Regarding a better overview, you're 100% right. This is something we've 
definitely not been good enough and we need to get better at.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119138/new/

https://reviews.llvm.org/D119138

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to