NoQ added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:107
+/// out of bounds.
+class IncrementGadget : public UnsafeGadget {
+ const UnaryOperator *Op;
----------------
xazax.hun wrote:
> How deep will the `Gadget` Hierarchy be? Using inheritance only to classify
> safe and unsafe gadgets feels like a very heavy weight solution to a
> relatively simple problem.
I'm expecting `UnsafeGadget` and `SafeGadget` to grow some common methods in
the future. But I'm already second-guessing this decision
(https://reviews.llvm.org/D137379?id=473092#inline-1340017) so I guess I'll
ungrow these intermediate classes if things become too tedious.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137348/new/
https://reviews.llvm.org/D137348
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
