aaron.ballman added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:60
@@ +59,3 @@
+ }
+}
+
----------------
Btw, with MSVC, this will give you a "not all control paths return a value"
warning. You should put an llvm_unreachable() after the switch to silence that
diagnostic.
================
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63
@@ +62,3 @@
+std::string SpecialMemberFunctionsCheck::join(
+ llvm::ArrayRef<SpecialMemberFunctionKind> SMFS, llvm::StringRef AndOr) {
+
----------------
Ah, crud, good point.
https://reviews.llvm.org/D22513
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
