vsk added a subscriber: vsk.
vsk added a comment.
This is neat!
I may be missing something, but could you explain why 'false-positives.cpp' was
deleted? I'd expect the test to be incorporated into 'functions.cpp' with the
'expected-*' directives removed.
================
Comment at: lib/Analysis/CloneDetection.cpp:92
@@ +91,3 @@
+
+ VariableOccurence(std::size_t KindID) : KindID(KindID) {}
+ };
----------------
Extra 'std::' here.
================
Comment at: test/Analysis/copypaste/var-patterns.cpp:7
@@ +6,3 @@
+
+int max(int a, int b) { // expected-warning{{Detected code clone.}}
+ log();
----------------
This looks duplicated from 'functions.cpp'. Perhaps you could modify that test
case directly?
https://reviews.llvm.org/D22982
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
