jrbyrnes added a comment.

In D135269#3981856 <https://reviews.llvm.org/D135269#3981856>, @yaxunl wrote:

> In D135269#3981561 <https://reviews.llvm.org/D135269#3981561>, @nikic wrote:
>
>> Checking back here again on whether there is any progress on finding the 
>> root cause of the issue. If no progress is expected in the near future, I'd 
>> ask for this patch to be reverted.
>
> @jrbyrnes is working on the root cause of this issue. Any updates? Thanks.

Thanks for the ping. I would also like to see this reverted as it enables some 
optimizations. I do not have a definitive answer at the moment (w.r.t reverting 
this), but hope to provide one soon

As for now, the issue we are seeing from 
(https://github.com/llvm/llvm-project/commit/8018d6be3459780e81a5da128a9915eb27909902)
 seems most likely to be a source code issue (first document of issue 
https://github.com/pytorch/pytorch/issues/54789 . upstream PyTorch currently 
skips problematic test 
https://github.com/pytorch/pytorch/blob/b738da8c8e4d9142ad38a1bd8c35d0bfef4b5e3c/torch/testing/_internal/common_methods_invocations.py#L14891)
 . I will provide a better update soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135269/new/

https://reviews.llvm.org/D135269

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to