vsapsai added a comment. From my experience, `ShowInSystemHeader` for `-Rmodule-build` is overall useful. I haven't heard from people who want no remarks from system headers and the rest is just hypothetical guesses that can go both ways (some people might like one option while some people might like another option).
Don't have strong opinion about `-Rmodule-import` as don't use it extensively. But don't have any reasons to avoid consistency in this case, so `ShowInSystemHeader` for this flag makes sense. A test case would be great, especially I think that at some point I've seen remarks from system headers (though maybe it was with `-Wsystem-header`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139653/new/ https://reviews.llvm.org/D139653 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
