li.zhe.hua marked 2 inline comments as done. li.zhe.hua added inline comments.
================ Comment at: clang/lib/Tooling/Transformer/SourceCode.cpp:90-92 + Loc = Expansion.getExpansionLocStart(); + if (Loc.isFileID()) + return true; ---------------- ymandel wrote: > can you comment on the logic here? Why isn't this just "return true", since > it's in a macro but not a part of a macro arg, I'd think it must be part of a > macro definition. Good catch, it should just return true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139676/new/ https://reviews.llvm.org/D139676 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
