nridge resigned from this revision.
nridge added a comment.

In D138546#3980350 <https://reviews.llvm.org/D138546#3980350>, @cpsauer wrote:

> @nridge, I took a shot at amending the test. Thanks for the pointer! Please 
> me know if that looks good to you!

The test changes look good, thanks.

I'm going to leave the approval to Kadir because his comment sounded like he 
would maybe prefer for https://github.com/clangd/clangd/issues/1403 (note, it 
has a patch at D139277 <https://reviews.llvm.org/D139277>) to be fixed before 
merging this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138546/new/

https://reviews.llvm.org/D138546

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to