mstorsjo added a comment. In https://reviews.llvm.org/D22774#501993, @rengolin wrote:
> Can you add a test on test/Headers, like the others, please? Sure, there seems to be a good spot for that in ms-intrin.cpp. ================ Comment at: lib/Headers/armintr.h:1 @@ +1,2 @@ +/*===---- armintr.h - ARM intrinsics ---------------------------------------=== + * ---------------- rengolin wrote: > Maybe a hint that this is "ARM Windows Intrinsics"? Sure ================ Comment at: lib/Headers/armintr.h:27 @@ +26,3 @@ + +typedef enum +{ ---------------- rengolin wrote: > Maybe an ifdef Windows wrapper, to make sure not to mess up *nix environments? I can add the same as at the top of intrin.h, i.e. this: ``` /* Only include this if we're compiling for the windows platform. */ #ifndef _MSC_VER #include_next <intrin.h> #else ``` https://reviews.llvm.org/D22774 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits