arsenm added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2135
- llvm::AttrBuilder FuncAttrs(F->getContext());
- FuncAttrs.addAttribute("strictfp");
- F->addFnAttrs(FuncAttrs);
----------------
zahiraam wrote:
> I think it would better to fix this function instead of removing it entirely?
> The issue here is that there is the "strictfp" attribute and the
> llvm::Attribute::StrictFP. We could replace
> FuncAttrs.addAttribute("strictfp"); with
> FuncAttrs.addAttribute(llvm::Attribute::StrictFP);
> This function ensures that the function attribute is set when the
> FunctionDecl attribute is set. I am concerned that when it's removed, we will
> wind up with cases where the function attribute is missing! The only place
> where this function attribute is in CodeGenFunction::StartFunction. Is that
> enough? @andrew.w.kaylor Can you please weigh in on this?
I currently don't have evidence that making this use the correct attribute
would fix anything. If something was depending on this emission in this
context, it's already broken
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139629/new/
https://reviews.llvm.org/D139629
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
