omtcyfz added inline comments. ================ Comment at: clang-rename/tool/clang-rename.el:20 @@ +19,3 @@ + "Rename all instances of the symbol at the point using clang-rename" + (interactive "sEnter a new name: ") + (let (;; Emacs offset is 1-based. ---------------- hokein wrote: > `s` is an extra character here? No, it tells Emacs to read a string.
================ Comment at: clang-rename/tool/clang-rename.el:27 @@ +26,3 @@ + (let ((rename-command + (format "bash -f -c '%s -offset=%s -new-name=%s -i %s'" + clang-rename-binary offset new-name file-name))) ---------------- hokein wrote: > Any reason why not use `call-process-region`? /* discussed */ https://reviews.llvm.org/D23006 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
