alexfh requested changes to this revision. This revision now requires changes to proceed.
================ Comment at: test/clang-rename/FunctionOverride.cpp:3 @@ +2,3 @@ + +class A { virtual void foo(); }; // CHECK: class A { virtual void boo(); }; +class B : public A { void foo(); }; // CHECK: class B : public A { void boo(); }; ---------------- I guess, this test will pass even if clang-rename doesn't do any changes, since the pattern in the CHECK line will match with itself. There are multiple ways to fix this. For instance, you can anchor the pattern to the start of line (`// CHECK: {{ˆ}}class A ...`) or add `| sed 's,//.*,//'` to the pipeline before `| FileCheck %s`. https://reviews.llvm.org/D23009 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits