Michael137 added inline comments.
================ Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by ---------------- dblaikie wrote: > aprantl wrote: > > It looks like all the other namespaces in Clang are all lowercase? > Yeah, +1 to the naming. > > & maybe not introducing a new "utils" bucket - they can be a bit of a dumping > ground. Could this operation belong elsewhere/in some existing type, or maybe > doesn't need a namespace wrapper - could be a free function in the `clang` > namespace?) I suppose this could just be a static function on `clang::TypePrinter`. We use it from `CGDebugInfo` already anyway so it wouldn't be an extra dependency. Wdyt? @aprantl @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139985/new/ https://reviews.llvm.org/D139985 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits