doru1004 added inline comments.
================
Comment at: clang/test/OpenMP/declare_target_nohost_variant_messages.cpp:16
+#pragma omp declare target enter(fun2) device_type(nohost)
+#pragma omp declare variant(host_function) match(device={kind(host)})
+void fun2() {}
----------------
doru1004 wrote:
> ABataev wrote:
> > You mean this test case? But it still has kind(host).
> The condition checks the attribute of the `host_function` which in this case
> is `host`. In the test above the condition is false because the
> `not_a_host_function` has a `nohost` attribute.
It should always have host there because we are trying to fix the case where we
have a nohost function that needs a host variant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140155/new/
https://reviews.llvm.org/D140155
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
