balazske added inline comments.
================
Comment at:
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1818-1857
+ // int fgetpos(FILE *restrict stream, fpos_t *restrict pos);
+ // From 'The Open Group Base Specifications Issue 7, 2018 edition':
+ // "The fgetpos() function shall not change the setting of errno if
+ // successful."
+ addToFunctionSummaryMap(
+ "fgetpos",
+ Signature(ArgTypes{FilePtrRestrictTy, FPosTPtrRestrictTy},
----------------
Szelethus wrote:
> martong wrote:
> > It is very good to see these new summaries! Would they be meaningful and
> > usable without the changes in the StreamChecker? If yes, then I think we
> > should split this into 2 patches.
> Can you please do this?
This is done now. There were 2 consecutive patches that modify
`StdLibraryFunctionsChecker` and other checkers. These are rearranged into 2
new patches. One for all changes in `StdLibraryFunctionsChecker` (and related
changes in ErrnoModeling): D140387. Other for all other changes,
`StreamChecker` and many of the tests that exercise both checkers: D140395.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135360/new/
https://reviews.llvm.org/D135360
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
