kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
thanks, lgtm! ================ Comment at: clang-tools-extra/clangd/ClangdServer.cpp:86 + auto Task = [ + // Captured by value + LO(*CI.getLangOpts()), Loc(std::move(Loc)), ---------------- formatting seems to be off here (looks like clang-format can't deal with this leading comment. do you mind dropping it? the comment above makes it clear that we shouldn't be keeping references already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140486/new/ https://reviews.llvm.org/D140486 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
