HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the expression is ---------------- rymiel wrote: > HazardyKnusperkeks wrote: > > HazardyKnusperkeks wrote: > > > The comment needs to be adapted. > > > > > > But I think it could just be merged into the parsing of the requires > > > clause, or not? > > Actually this needs to be done on D140339. > You are right, thank you. D140339 will make it so `parseConstraintExpression` > will only ever be called from `parseRequiresClause`. Should I do that > refactor in D140339 or leave it for a future patch? Either way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140312/new/ https://reviews.llvm.org/D140312 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits