rupprecht added a comment. In D136554#4018870 <https://reviews.llvm.org/D136554#4018870>, @rupprecht wrote:
> All good now! The latest revision of this patch doesn't seem to break > anything, unless I ran our tests wrong. From my perspective this is OK to > reland now. ... and yep, I was holding it wrong. There are still build failures, this time in linking, where LLD reports some symbols are undefined. I'm not certain yet if this really a problem with this patch (e.g. sometimes we see files break like this when users put their template code in the .cpp files and not the .h files), but the source code doesn't look immediately wrong. Once again, I'll try to reduce something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
