XiaodongLoong added a comment. @xen0n Thanks for your suggestion.
================ Comment at: llvm/lib/Target/LoongArch/LoongArchInstrInfo.td:53 + SDTCisVT<1, GRLenVT>]>; +def SDT_LoongArchFCSR2GR : SDTypeProfile<1, 1, [SDTCisVT<0, GRLenVT>, + SDTCisVT<1, i32>]>; ---------------- xen0n wrote: > Be consistent with the surrounding code and spell out the instruction > mnemonic fully? Like `SDT_LoongArchMovfcsr2gr`? Thanks, I changed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140685/new/ https://reviews.llvm.org/D140685 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits