arsenm added inline comments.
================ Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + ---------------- Joe_Nash wrote: > What part of the toolchain is responsible for forbiding flat pointers on > unsupported targets? The frontend should just error on languages with flat pointers. Really we should just implement software flat pointers, it wouldn’t be difficult and might only require minimal driver cooperation if any CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
