gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:97-106 + // FIXME: This is sort of workaround. Since now we just ignore all (implicit) + // integral casts, treating the resulting value as the same as the underlying + // value, it could cause inconsistency between values after `Join` if in + // some paths the type doesn't strictly match: + // + // std::optional<bool> o; + // int x; ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140753/new/ https://reviews.llvm.org/D140753 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits