tom-anders added inline comments.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:808
+void maybeAddCalleeArgInfo(const SelectionTree::Node *N, HoverInfo &HI,
+ const PrintingPolicy &PP);
----------------
(I also modified this function, so I added this forward declaration for easier
review.
If this patch gets accepted, I'd move the definition up to here before landing)
================
Comment at: clang-tools-extra/clangd/Hover.cpp:830
+ if (HI.CalleeArgInfo) {
+ HI.Name = "literal";
+ return HI;
----------------
`HoverInfo::present` has an assertion that the `Name` has to be non-empty. I'm
open for other name suggestions here (Or we could of course adjust
`HoverInfo::present` instead)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140775/new/
https://reviews.llvm.org/D140775
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
