yonghong-song added a comment.

Please separate the patch to clang and llvm part.



================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4218
+  // DISubprogram's retainedNodes in the subsequent finalizeSubprogram call.
+  if (IsDeclForCallSite && CGM.getTarget().getTriple().isBPF()) {
+    if (auto *FD = dyn_cast<FunctionDecl>(D)) {
----------------
Looks like this is for bpf only? Can we extend it to non-bpf as well? 
Currently, I think most use case, if any, will be in vmlinux (e.g., for 
struct_ops callback, etc).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140929/new/

https://reviews.llvm.org/D140929

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to