phosek added inline comments.
================ Comment at: clang/include/clang/Driver/Multilib2.h:33-34 +private: + std::vector<std::tuple<std::string, std::vector<std::string>, std::vector<std::string>>> Multilibs; + std::vector<std::tuple<std::string, std::vector<std::string>, std::vector<std::string>>> RegexAttributes; +}; ---------------- I think it'd really help readability and comprehension if this was modeled using types (that is `struct`s and `class`es). It's not at all clear what these strings are supposed to represent, and seeing expressions like `std::get<0>` doesn't help either. ================ Comment at: clang/test/Driver/Inputs/baremetal_multilib/arm-none-eabi/multilib.yaml:24 +- path: thumb/v6-m/nofp + args: [--target=arm-none-eabi, -mfloat-abi=soft, -march=armv6m] + attrs: [thumb, soft, v6m] ---------------- I understand how the second section is used to match arguments passed to `clang -cc1` and turn those into attributes which are then used to find the right variant, but I don't understand what this list of arguments is used for? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140959/new/ https://reviews.llvm.org/D140959 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
