cjdb added a comment.

LGTM, thanks for fixing!

Please be sure to have your commit message have `Fixes #59517` instead of a 
link to the issue, as this will close the bug upon merging.



================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/bugprone/standalone-empty.cpp:586-590
+  {
+    std::vector<int> v;
+    return std::empty(v);
+    // no-warning
+  }
----------------
Please add additional cases similar to what's above (e.g. a case with 
`absl::empty`, an ADL-invoked case, etc.).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141107/new/

https://reviews.llvm.org/D141107

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to