arsenm added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:2467-2468
+
+ const Function *Callee = CI->getCalledFunction();
+ if (Callee && (Callee->hasFnAttribute("dontcall-error") ||
+ Callee->hasFnAttribute("dontcall-warn"))) {
----------------
Misses constexpr casts and aliases
================
Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:2471
+ Metadata *MD = MDString::get(CI->getContext(),
CalledFunc->getName());
+ if (MDNode *N = CI->getMetadata("inlined-from")) {
+ TempMDTuple Temp = cast<MDTuple>(N)->clone();
----------------
metadata usually uses . word separators
================
Comment at: llvm/test/Transforms/Inline/dontcall-attributes.ll:8
+declare void @fof() "dontcall-error"="oh no"
+
+define void @bar(i32 %x) {
----------------
test alias case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141451/new/
https://reviews.llvm.org/D141451
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
