GMNGeoffrey accepted this revision.
GMNGeoffrey added a comment.
This revision is now accepted and ready to land.

LGTM (+/- nits), but maybe good to get review from someone more closely 
associated with the TestingSupport library



================
Comment at: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel:4464
 
+# Split out of TestingSupport to allow using this with a different gmock/gtest 
version.
+cc_library(
----------------
I think this comment is now a bit redundant


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141175/new/

https://reviews.llvm.org/D141175

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D141175: [te... Geoffrey Martin-Noble via Phabricator via cfe-commits

Reply via email to