bkramer added inline comments. ================ Comment at: test/clang-tidy/google-global-names.cpp:13-14 @@ +12,4 @@ +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'i' declared in the global namespace +extern int ii = 0; +// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: 'ii' declared in the global namespace + ---------------- aaron.ballman wrote: > This strikes me as being intentional enough to warrant not diagnosing because > of the `extern` keyword. The only case I see where this pattern is valuable is interfacing with C code. Not sure yet if we want to allow that or enforce extern "C" instead. Ideas?
an extern global in the global namespace still feels like something we should warn on :| https://reviews.llvm.org/D23130 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
