carlosgalvezp added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/rename_check.py:311-314 + # TODO: remove below replacement when all clang-tidy checks have been + # updated with C++17 nested namespaces. replaceInFileRegex(filename, 'namespace ' + old_module + '[^ \n]*', 'namespace ' + new_namespace) ---------------- carlosgalvezp wrote: > Eugene.Zelenko wrote: > > njames93 wrote: > > > I'd argue the change to update all checks should go in at the same time. > > `Clang-tidy` or just `all checks`, since script is about Clang-tidy. > Patch for that here, would you like me to merge them? > > https://reviews.llvm.org/D141770 Let's do everything in the same patch, I'll abandon this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141769/new/ https://reviews.llvm.org/D141769 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits