jmmartinez added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:12581
+      Mod, HandleTy,
+      /*isConstant=*/true, llvm::GlobalValue::InternalLinkage,
+      /*Initializer=*/RuntimeHandleInitializer, RuntimeHandleName,
----------------
Just a cosmetical remark: Is there any reason to keep the `/*isConstant=*/`, 
`/*Initializer=*/`, ... comments? I think it would be better to avoid them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141700/new/

https://reviews.llvm.org/D141700

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D141... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH]... Anastasia Stulova via Phabricator via cfe-commits
    • [PATCH]... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH]... Juan Manuel Martinez Caamaño via Phabricator via cfe-commits

Reply via email to