njames93 added a comment. I'm not convinced this is the correct fix. The guildline <https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#i2-avoid-non-const-global-variables> states that tools should flag all variables declared at global or namespace scope. Therefore we shouldn't be flagging any class static members, no matter if they are public, private or protected.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141838/new/ https://reviews.llvm.org/D141838 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
