philnik accepted this revision. philnik added a comment. This revision is now accepted and ready to land.
LGTM from the libc++ side of things % nit. I think @aaron.ballman should take another look at the Clang changes. ================ Comment at: libcxx/utils/generate_header_tests.py:22 + "coroutine": "(defined(__cpp_impl_coroutine) && __cpp_impl_coroutine >= 201902L) || (defined(__cpp_coroutines) && __cpp_coroutines >= 201703L)", + ---------------- A `TODO LLVM17: simplify this to __cplusplus >= 202002L` would be nice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
