ChuanqiXu added a comment. In D137058#4058836 <https://reviews.llvm.org/D137058#4058836>, @Jake-Egan wrote:
> In D137058#4057424 <https://reviews.llvm.org/D137058#4057424>, @ChuanqiXu > wrote: > >> In D137058#4056647 <https://reviews.llvm.org/D137058#4056647>, @Jake-Egan >> wrote: >> >>> Hi, this new test fails on AIX >>> https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm >>> Could you take a look? >> >> I added `// REQUIRES: x86-registered-target`. Is it still failing? > > It is still failing yes, I think it should restrict `system-aix` instead, > like you did on windows. Got it. Could you help to add this? Since I can't test it properly. > My concern is that when it becomes necessary it won't be apparent - someone > will fix (or introduce) a bug in one codepath, unaware of the other similar > codepath. Unifying them before that happens is valuable. Understood. I just felt that the `tools::SplitDebugName` and `GetModuleOutputPath` have more different points than common points. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
