eopXD added inline comments.

================
Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:977
 
+llvm::SmallVector<Policy> RVVIntrinsic::getSupportedUnMaskedPolicies() {
+  return {
----------------
craig.topper wrote:
> Possible improvement for a different patch:
> 
> Could these policy lists be static const arrays and this function could 
> returned an ArrayRef pointing to the appropriate list instead constructing a 
> SmallVector?
Yes. I will use a flyweight pattern to simplify things here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141573/new/

https://reviews.llvm.org/D141573

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to