ckandeler added a comment.
In D139926#4064769 <https://reviews.llvm.org/D139926#4064769>, @kadircet wrote:
>> We can easily check the actual character at the given position in the
>> client, so I could just merge the two highlighting kinds.
>
> Thanks! Note that it might not be as easy at the face of templates, eg:
>
> #define LESS <
> template LESS typename T > class A {};
At least this one doesn't seem to be an issue; added test case.
================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:54
Operator,
+ AngleBracket,
----------------
kadircet wrote:
> actually let's name these as `Bracket` rather than `AngleBracket`, as we
> might want to increase the coverage further in the future (and a use case
> such as yours can still look at the textual tokens to match relevant
> brackets).
Yes, I was going to suggest this myself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139926/new/
https://reviews.llvm.org/D139926
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
