awarzynski added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:485-486
 
+// Works like BoolOption except without specifying a KeyPathAndMacro, as these
+// would refer to non-existant members of clang data structures
+multiclass BoolFlangOnlyOption<string prefix = "", string spelling_base,
----------------
[nit] To me `KeyPathAndMacro` is just an implementation detail. The key part is 
that `BoolOption` does use the marshaling infra and `BoolFlangOnlyOption` does 
not. Perhaps rename as `BoolOptionWithoutMarshalling`? There isn't anything 
Flang specific here, is there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140972/new/

https://reviews.llvm.org/D140972

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to