jhuber6 marked 2 inline comments as done.
jhuber6 added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10515
+ default:
+ RequiresFlags.push_back(OMP_REQ_NONE);
+ }
----------------
jdoerfert wrote:
> Really? Not an error or unexpected state?
Probably a good point. Would this be an unreachable? Since I think Sema should
catch anything we don't expect here.
================
Comment at: openmp/libomptarget/src/rtl.cpp:360
+ if (Desc->Version >= 0)
return;
----------------
jdoerfert wrote:
> Why do we allow to be called with an old struct, wouldn't we have converted
> it at this point?
Leftover, will remove.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133539/new/
https://reviews.llvm.org/D133539
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
