tmatheson accepted this revision.
tmatheson added a comment.
This revision is now accepted and ready to land.
Looks great, thanks
================
Comment at: llvm/include/llvm/TargetParser/AArch64TargetParser.h:338
+
+ uint64_t getDefaultExtensions() const {
+ return DefaultExtensions | Arch.DefaultExts;
----------------
nit: I would expect `getDefaultExtensions()` to return the value of
`DefaultExtensions`. Is there a better naming combo we could use?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142540/new/
https://reviews.llvm.org/D142540
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
