foad added a comment. In D142823#4093363 <https://reviews.llvm.org/D142823#4093363>, @arsenm wrote:
> In D142823#4093357 <https://reviews.llvm.org/D142823#4093357>, @foad wrote: > >> I think the tablegen functionality should be a separate patch from the >> amdgpu changes. > > Maybe, but then it’s untested in the patch which adds it Not if you add a test. There are some already like test/TableGen/immarg.td and test/TableGen/intrin-side-effects.td. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
