aaron.ballman added inline comments.
================ Comment at: clang/docs/ReleaseNotes.rst:45-46 +- -Wtype-limits added to -Wextra for GCC compatibility. This fixes + `Issue 58375 <https://github.com/llvm/llvm-project/issues/58375>`_. + ---------------- I'd move this into bug fixes as I don't think this is enough of a potential disruption to warrant putting it here. If we get user feedback about surprises, we might move it back to here later. ================ Comment at: clang/test/Sema/tautological-constant-compare.c:7-8 // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wtype-limits -DTEST -verify -x c++ %s -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra -Wno-sign-compare -verify=silent %s -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra -Wno-sign-compare -verify=silent -x c++ %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra -Wno-sign-compare -Wno-type-limits -verify=silent %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wextra -Wno-sign-compare -Wno-type-limits -verify=silent -x c++ %s // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsyntax-only -Wall -verify=silent %s ---------------- I'd change this the other way; this way we demonstrate that `-Wextra` is what enabled `-Wtype-limits`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
