kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
In D139926#4091990 <https://reviews.llvm.org/D139926#4091990>, @nridge wrote: > but it sounds like you've looked at that well i did now :P --- thanks a lot to you both, let's ship it! ================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:408 + addToken(*RRange, HighlightingKind::Bracket); + } + } ---------------- nit: i'd actually keep the `return;` here to make sure we don't fall into handling of other cases implicitly in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
