bcain added a subscriber: ldionne. bcain added a comment. It seems extremely unlikely that this change to target-dependent flags caused this libc++ test failure w/an error referring to partial specialization.
@ldionne is it possible that `special_mem_concepts::nothrow_sentinel_for.compile.pass.cpp` is failing on the baseline? In module 'std' imported from /home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp:14: /home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1/__concepts/same_as.h:29:34: error: partial specialization of 'common_reference<_Tp, _Up>' must be imported from module 'std.type_traits.common_reference' before it is required concept same_as = __same_as_impl<_Tp, _Up> && __same_as_impl<_Up, _Tp>; ^ /home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/libcxx/test/libcxx/algorithms/specialized.algorithms/special.mem.concepts/nothrow_sentinel_for.compile.pass.cpp:23:80: note: while substituting into concept arguments here; substitution failures not allowed in concept arguments constexpr bool ntsf_subsumes_sf(std::ranges::__nothrow_sentinel_for<char*> auto) requires true { ^ /home/libcxx-builder/.buildkite-agent/builds/7288bc8bb028-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1/__type_traits/common_reference.h:133:40: note: partial specialization declared here is not reachable template <class _Tp, class _Up> struct common_reference<_Tp, _Up> : __common_reference_sub_bullet1<_Tp, _Up> {}; ^ 1 error generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142947/new/ https://reviews.llvm.org/D142947 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits