dblaikie added a comment.

> I'd be interested to see the fixit-hints for the first bit, also to see how 
> others feel about it here.

My 2c is that `-Wparentheses` is already a very stylistic warning (even correct 
code, without knowing about this esoteric/specific suppression style of adding 
parens, is likely to be caught by this general class of diagnostic) so I'm 
pretty apprehensive about opening it up further - but data would be the 
decider. Running the proposed slices (different operators in different orders, 
etc) of warning over some broad codebases to get a sense of the false positive 
rate would be really helpful/necessary to decide which things to include and 
exclude.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142800/new/

https://reviews.llvm.org/D142800

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to