Joe added a comment.

So again, I took these patches for a spin with RISC-V. As I mentioned before, I 
was using a GCC installation, so the multilib selection happens inside Gnu.cpp 
(findRISCVBareMetalMultilibs). The main trouble I had was at that point we 
don't have a reference to the ToolChain, so calling `getMultiSelectionFlags` 
was not possible. I had a go at making this function static, and it was mostly 
fine as you could just pass in the Triple and Driver, however 
`getSanitizerArgs` was not possible. I'm not sure what the solution here is.

Multilibs for RISCV are straightforward, they just depend arch+abi, so I added 
the arch extensions and abi to the Result in `getMultiSelectionFlags`.

With that modified `getMultiSelectionFlags`, it worked well :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142933/new/

https://reviews.llvm.org/D142933

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to