erichkeane added inline comments.

================
Comment at: clang/lib/Sema/SemaChecking.cpp:17816
+  if (!TyArg->isBuiltinType() && !TyArg->isVectorType()) 
+    Diag(TheCall->getArg(0)->getBeginLoc(), diag::err_builtin_invalid_arg_type)
+           << 1 << /*vector, integer or floating point ty*/ 0 << TyArg;
----------------
This should set the expression as invalid, shouldn't it?  That way we don't end 
up depending on it too much.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142388/new/

https://reviews.llvm.org/D142388

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to